ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 62538: Good coding practice in Ranger recommended by static code analysis
Date Tue, 26 Sep 2017 12:04:23 GMT


> On Sept. 25, 2017, 2:08 p.m., Colm O hEigeartaigh wrote:
> > Why not just change the existing for loops to use "roleSysAdminMap.entrySet()" instead
of adding an Iterator?
> 
> Fatima Khan wrote:
>     In coverity scan, we had got FB.WMI_WRONG_MAP_ITERATOR issue. To solve this i used
roleSysAdminMap.entrySet(), if we use Iterator, then we might get the same coverity issue.

I don't understand, the diff for this issue shows Iterator being used and not entrySet?


- Colm


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62538/#review186118
-----------------------------------------------------------


On Sept. 25, 2017, 10:44 a.m., Fatima Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62538/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 10:44 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1806
>     https://issues.apache.org/jira/browse/RANGER-1806
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice in Ranger recommended by static code analysis on
> 1.RoleBasedUserSearchUtil.java
> 2.TestRoleBasedUserSearchUtil.java
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/patch/cliutil/RoleBasedUserSearchUtil.java
0459be6 
>   security-admin/src/test/java/org/apache/ranger/patch/cliutil/TestRoleBasedUserSearchUtil.java
83eab7a 
> 
> 
> Diff: https://reviews.apache.org/r/62538/diff/1/
> 
> 
> Testing
> -------
> 
> 1.Tested SSO Authentication
> 2.Junit test was successful
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message