ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 62024: RANGER-1756: Handle role related restrictions for users having User role.
Date Tue, 26 Sep 2017 17:37:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62024/#review186293
-----------------------------------------------------------


Fix it, then Ship it!





security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Line 358 (original), 367 (patched)
<https://reviews.apache.org/r/62024/#comment262769>

    Nitpick here, but should have a space before and after = sign.
    Same in line 353 and 382


- Alejandro Fernandez


On Sept. 25, 2017, 5:05 a.m., Nitin Galave wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62024/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 5:05 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Fatima Khan, Gautam Borad, Mehul Parikh, and
Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1756
>     https://issues.apache.org/jira/browse/RANGER-1756
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Handle role related restrictions for users having User role.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 739ea05 
>   security-admin/src/main/webapp/scripts/utils/XAUtils.js ecf43ad 
> 
> 
> Diff: https://reviews.apache.org/r/62024/diff/3/
> 
> 
> Testing
> -------
> 
> Verified scenario's :
> 1. A user with ROLE_ADMIN able to see users which has USER_ROLE/ADMIN_ROLE.
> 2. A user with ROLE_KEYADMIN able to see users which has USER_ROLE/KEYADMIN_ROLE.
> 3. A user with role ROLE_USER able to see only himself.
> 
> 
> Thanks,
> 
> Nitin Galave
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message