ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colm O hEigeartaigh <cohei...@apache.org>
Subject Re: Review Request 62650: Object HTableDescriptor can be used directly at getTableList() method for HBaseClient class
Date Thu, 28 Sep 2017 11:40:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62650/#review186544
-----------------------------------------------------------


Ship it!




Ship It!

- Colm O hEigeartaigh


On Sept. 28, 2017, 1:38 a.m., wang yuan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62650/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 1:38 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,
Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and
Qiang Zhang.
> 
> 
> Bugs: RANGER-1812
>     https://issues.apache.org/jira/browse/RANGER-1812
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Object HTableDescriptor can be used directly at getTableList() method for HBaseClient
class
> 
> {code:title=HBaseClient.java}
> public List<String> getTableList(final String tableNameMatching, final List<String>
existingTableList ) throws HadoopException {
>     ... ...
>     HTableDescriptor [] htds = admin.listTables(tableNameMatching);
>     if (htds != null) {
>         for (HTableDescriptor htd : admin.listTables(tableNameMatching)) {
>         // The object htds can be used directly inestead of listTables once again 
>         // for (HTableDescriptor htd : htds )  
> 	      String tableName = htd.getNameAsString();
> 	      if (existingTableList != null && existingTableList.contains(tableName))
{
> 		    continue;
> 	      } else {
> 		     tableList.add(htd.getNameAsString());
> 	      }
> 	 }
>      }
>     ... ...
> }
> {code}
> 
> 
> Diffs
> -----
> 
>   hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java
d9870e39 
> 
> 
> Diff: https://reviews.apache.org/r/62650/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wang yuan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message