ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alejandro Fernandez <afernan...@hortonworks.com>
Subject Re: Review Request 62659: RANGER-1814 : Move the reader into a local variable in LocalFileLogBuffer
Date Thu, 28 Sep 2017 17:25:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62659/#review186584
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Sept. 28, 2017, 11:27 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62659/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 11:27 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1814
>     https://issues.apache.org/jira/browse/RANGER-1814
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Static code analyser flagged sendCurrentFile in LogFileLogBuffer as dubious BufferedReader
usage - because it's not clear if that reader is closed properly. Suggested to move from instance
variable to method local variable
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/LocalFileLogBuffer.java
56a24ed 
> 
> 
> Diff: https://reviews.apache.org/r/62659/diff/1/
> 
> 
> Testing
> -------
> 
> Tested locally, travis build: https://travis-ci.org/gzsombor/ranger/builds/280822647
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message