ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fatima Khan <fatimakhan4...@gmail.com>
Subject Review Request 62713: RANGER 1818: Good coding practice in Ranger recommended by static code analysis
Date Sat, 30 Sep 2017 10:17:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62713/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-1818
    https://issues.apache.org/jira/browse/RANGER-1818


Repository: ranger


Description
-------

Good coding practice in Ranger recommended by static code analysis on the last commit made.Instead
of printing the entire object we are printing only the error message that gives clear information
about the error.


Diffs
-----

  unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java
0b3d2e6 
  unixauthservice/src/main/java/org/apache/ranger/authentication/PasswordValidator.java 20ced89



Diff: https://reviews.apache.org/r/62713/diff/1/


Testing
-------

1.Tested SSO Authentication
2.Junit test was successful


Thanks,

Fatima Khan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message