ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 65777: RANGER-1967 - Kafka 1.0 support
Date Tue, 27 Feb 2018 06:37:33 GMT


> On 二月 26, 2018, 4:30 p.m., Colm O hEigeartaigh wrote:
> > > JaasContext context = JaasContext.load(Type.SERVER, new ListenerName("KafkaServer"),
configs);
> > 
> > Should "KafkaServer" be configurable here?
> > 
> > Apart from that looks good to me - have you tested the plugin with a Kafka 1.0.0
deployment?

We configure listeners in server.properties as following:
listeners=SASL_PLAINTEXT://HDC90:9092

In order to above function, I write following code and execute succefully:
String listeners = (String)configs.get("listeners");
...
JaasContext jaasContext = JaasContext.load(JaasContext.Type.SERVER, new ListenerName(listeners.split(":")[0]),
configs);

ListenerName("KafkaServer")

"KafkaServer" should equal to SASL_PLAINTEXT.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65777/#review198284
-----------------------------------------------------------


On 二月 24, 2018, 10:08 a.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65777/
> -----------------------------------------------------------
> 
> (Updated 二月 24, 2018, 10:08 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1967
>     https://issues.apache.org/jira/browse/RANGER-1967
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The API changes are not too big, however running Kafka in embedded mode turned out to
be a bit trickier beast. I had to add a couple of new flags, otherwise it would wait for 2
other broker to join.
>  The commit also contains logging changes, even a test log4j configuration, just to make
the debugging easier.
> 
> 
> Diffs
> -----
> 
>   agents-audit/pom.xml 4fa44c5f 
>   plugin-kafka/pom.xml f644646b 
>   plugin-kafka/src/main/java/org/apache/ranger/authorization/kafka/authorizer/RangerKafkaAuthorizer.java
b3d5a74d 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerGSSTest.java
4ea39ed7 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java
fb541cd3 
>   plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
fb0a2c0f 
>   plugin-kafka/src/test/resources/log4j.properties PRE-CREATION 
>   pom.xml fa1d1c7b 
>   ranger-kafka-plugin-shim/pom.xml f1aeee6f 
> 
> 
> Diff: https://reviews.apache.org/r/65777/diff/2/
> 
> 
> Testing
> -------
> 
> Unit & local tests
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message