ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil P <npur...@gmail.com>
Subject Re: Review Request 67545: Good coding practices for REST classes and unit tests
Date Thu, 14 Jun 2018 14:01:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67545/
-----------------------------------------------------------

(Updated June 14, 2018, 7:31 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2133
    https://issues.apache.org/jira/browse/RANGER-2133


Repository: ranger


Description
-------

Good coding practices for REST classes and unit tests


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java c206acb 
  security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 15ed862 
  security-admin/src/test/java/org/apache/ranger/rest/TestXUserREST.java 529fd5b 
  security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java
f4ea957 


Diff: https://reviews.apache.org/r/67545/diff/2/

Changes: https://reviews.apache.org/r/67545/diff/1-2/


Testing
-------

tested on local machine.


Thanks,

Nikhil P


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message