ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhavik patel <bhavikpatel...@gmail.com>
Subject Re: Review Request 67642: RANGER-2132 : Add unit tests for org.apache.ranger.common package
Date Tue, 19 Jun 2018 11:20:58 GMT


> On June 19, 2018, 10:05 a.m., Zsombor Gegesy wrote:
> > security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java
> > Line 110 (original), 112 (patched)
> > <https://reviews.apache.org/r/67642/diff/1/?file=2042279#file2042279line113>
> >
> >     Order of the elements in a set is not defined, this test could brake intermittenly.
Why not compare as sets? 
> >     Set<String> expectedSet = new HashSet(Arrays.asList("hive", "hdfs", "knox"));
> >     
> >     Set<String> actualSet = jsonUtil.writeJsonToJavaObject("[\"hdfs\",\"hive\",\"knox\"]",
HashSet.class);

We are passing the predefined json string to method  jsonUtil.writeJsonToJavaObject  which
always result into fixed set having same order of the elements.

It should not be an issues.
However we can also compare using set as well.


- bhavik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67642/#review204994
-----------------------------------------------------------


On June 19, 2018, 9:46 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67642/
> -----------------------------------------------------------
> 
> (Updated June 19, 2018, 9:46 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and
Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2132
>     https://issues.apache.org/jira/browse/RANGER-2132
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Fix Coverity Scan issue
> 
> 
> Diffs
> -----
> 
>   security-admin/src/test/java/org/apache/ranger/common/TestDateUtil.java 8b7d34f 
>   security-admin/src/test/java/org/apache/ranger/common/TestJSONUtil.java 0daf7f1 
>   security-admin/src/test/java/org/apache/ranger/common/TestServiceUtil.java 90a93ae

> 
> 
> Diff: https://reviews.apache.org/r/67642/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message