ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qiang Zhang <zhangqia...@zte.com.cn>
Subject Re: Review Request 69239: RANGER-2276:Email Address should be verified when Add New User in Ranger Admin
Date Mon, 12 Nov 2018 08:35:49 GMT


> On 十一月 9, 2018, 9:29 a.m., pengjianhua wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/69239/diff/1/?file=2103713#file2103713line31>
> >
> >     This path has conflicts, StringUtils is already defined in the latest code.
> >     
> >     security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java:[89] error:
org.apache.commons.lang.StringUtils is already defined in a single-type import

OK, thanks.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69239/#review210436
-----------------------------------------------------------


On 十一月 12, 2018, 8:34 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69239/
> -----------------------------------------------------------
> 
> (Updated 十一月 12, 2018, 8:34 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam
Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, Venkat
Ranganathan, Velmurugan Periasamy, and Zsombor Gegesy.
> 
> 
> Bugs: RANGER-2276
>     https://issues.apache.org/jira/browse/RANGER-2276
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Click Add New User in Ranger Admin to create user,
> and fill in Email Address with a@b.c, user can be created successfully.
> But when you update the user with Email Address like x@y.z,
> update would be failed with the following message:
> Error:Please provide valid email address.
> Please refer screenshots:
> [UpdateUserWithEmail.jpg|https://issues.apache.org/jira/secure/attachment/12946646/UpdateUserWithEmail.jpg]
> Email Address should be verified when creating users like updating users.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java ced600f 
> 
> 
> Diff: https://reviews.apache.org/r/69239/diff/2/
> 
> 
> Testing
> -------
> 
> Tested:
> Email Address is verified when Add New User in Ranger Admin.
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message