ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Koncz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (RANGER-2255) Add JavaScript unit tests
Date Wed, 09 Jan 2019 11:40:00 GMT

    [ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738135#comment-16738135

Csaba Koncz commented on RANGER-2255:

[~pradeep.agrawal]: my change does not add any functionality, so yes, it can be reverted.

On the other hand I would like to have some minimal JavaScript testing, so can we try to save

I ran npm in a clean CentOS container (centos:7.5.1804) and it failed for me, too.

It turned out that I need to install bzip2 and fontconfig. (yum install bzip2 fontconfig).
Fontconfig is not needed for installation, only for the PhantomJS binary itself.

The situation is the same with Debian 9: `apt-get update; apt-get install bzip2 fontconfig`
is needed.

Additionally, I can make JavaScript test execution disabled by default and run it only when
an extra system property is specified (.e.g. -Djstests=true).

> Add JavaScript unit tests
> -------------------------
>                 Key: RANGER-2255
>                 URL: https://issues.apache.org/jira/browse/RANGER-2255
>             Project: Ranger
>          Issue Type: Wish
>          Components: admin
>    Affects Versions: 0.7.0, 2.0.0, 1.2.1
>            Reporter: Csaba Koncz
>            Assignee: Csaba Koncz
>            Priority: Minor
>             Fix For: 2.0.0
> It would be nice if the admin-ui project would have JavaScript unit tests.
> As with RANGER-2220 JavaScript minification was introduced, that can lead to new type
of loading errors that were not seen before.
> It would be nice if there was an automatic check that validates the minified output.

This message was sent by Atlassian JIRA

View raw message