ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhavik patel <bhavikpatel...@gmail.com>
Subject Re: Review Request 70057: RANGER-2324 Bootstrapping Solr in Ranger service start-up
Date Mon, 18 Mar 2019 14:58:21 GMT


> On March 14, 2019, 11:44 p.m., Oliver Szabo wrote:
> > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrSetupUtil.java
> > Lines 63 (patched)
> > <https://reviews.apache.org/r/70057/diff/3/?file=2132313#file2132313line63>
> >
> >     overall, it's much closer for that how i thought it first how it should work.

> >     
> >     few things:
> >     - would make sense to rename this thread to something else, because it's not
realy a util class, maybe SolrCollectionBoostrapper or something similar.
> >     
> >     - not only ranger should be used as sasl user (like ranger should be able to
edit the configs, but solr user as well), it should be a way to provide additional users,
because with Ambari/CM, that will be needed.
> >     
> >     - what if solrconfig.xml is changed on the filesystem? because it should be
uploaded again by the bootstrapper on startup. (TTL can be changed in the solrconfig.xml,
but in that case we can just upload that file, as for example, managed-schema mostly edited
by Solr itself, so that one should not be touched) ... so that solrconfig.xml file should
be downloaded to the application memory from the znode and check is it differs from the uploaded
one. 
> >     
> >     - an atomic shared variable would be useful (for example that can be passed
by the constructor) that can be used even on REST API side to filter out any Solr Query and
answer that Solr is not ready yet (or ZK) ... but this is not really essential of course

1.) Changed the name from SolrSetupUtil.java to SolrCollectionBoostrapper.java
2.) Added new prop for sasl users
3.) When any changes are been made in solrconfig.xml, as it the configuration changes we need
to restart the ranger. On restart we check the content of solrconfig.xml in uploadConfiguration()
---> doIfConfigExists() ---> updateConfigIfNeeded() and in case it differ we do re upload
new solrconfig.xml


- bhavik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70057/#review213730
-----------------------------------------------------------


On March 14, 2019, 3:31 p.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70057/
> -----------------------------------------------------------
> 
> (Updated March 14, 2019, 3:31 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja
Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2324
>     https://issues.apache.org/jira/browse/RANGER-2324
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> We are handling the solr bootstrapping in below mentioned manner for Ranger
> 1.) Connection to solr
> 2.) Upload Configuration
> 3.) Create Collection
> 4.) Setting ACL
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
8d32352 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrSetupUtil.java
PRE-CREATION 
>   security-admin/scripts/install.properties fdcee1b 
>   security-admin/scripts/setup.sh bd4bd4c 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 686f720 
>   security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 4d4a1de 
>   src/main/assembly/admin-web.xml 8ea728b 
> 
> 
> Diff: https://reviews.apache.org/r/70057/diff/3/
> 
> 
> Testing
> -------
> 
> Tested Below Scenario on ranger manual start / restart
> 1.) Solr configuration were uploaded successfully
> 2.) Solr collections were created successfully
> 3.) ACL were setup as required.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message