ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service
Date Thu, 02 May 2019 22:38:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70565/#review215005
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java
Line 80 (original), 85 (patched)
<https://reviews.apache.org/r/70565/#comment301298>

    please update the patch.
    
    ```
    $ git apply --check -v /Users/vperiasamy/Downloads/RANGER-2411.patch
    Checking patch security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java...
    Hunk #1 succeeded at 43 (offset 2 lines).
    Hunk #2 succeeded at 57 (offset 2 lines).
    error: while searching for:
        @Autowired
        RangerBizUtil bizUtil;
    
        @POST
        @Path("/zones")
        public RangerSecurityZone createSecurityZone(RangerSecurityZone securityZone) {
    
    error: patch failed: security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java:85
    error: security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java: patch
does not apply
    Checking patch security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java...
    ```


- Velmurugan Periasamy


On April 29, 2019, 8:11 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70565/
> -----------------------------------------------------------
> 
> (Updated April 29, 2019, 8:11 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal,
Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2411
>     https://issues.apache.org/jira/browse/RANGER-2411
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Restrict Admin role user to create Zone for KMS service
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 6ce5365 
>   security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java edb3102

> 
> 
> Diff: https://reviews.apache.org/r/70565/diff/1/
> 
> 
> Testing
> -------
> 
> Tested if Admin user is not able to create zone for KMS service.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message