ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 71465: RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled for ranger_audits collection
Date Tue, 10 Sep 2019 23:46:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71465/#review217683
-----------------------------------------------------------




plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
Lines 60 (patched)
<https://reviews.apache.org/r/71465/#comment304994>

    If access is denied, it should be logged, right? Please review.



plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
Lines 72 (patched)
<https://reviews.apache.org/r/71465/#comment304995>

    Is it required to be defined for this class if all it does is to call its superclass method?


- Abhay Kulkarni


On Sept. 10, 2019, 11:18 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71465/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2019, 11:18 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2564:Avoid recursive audit log in Solr Plugin by user solr when plugin is enabled
for ranger_audits collection
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
c8ba6dd 
>   plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java
PRE-CREATION 
>   plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
5fcd45d 
> 
> 
> Diff: https://reviews.apache.org/r/71465/diff/1/
> 
> 
> Testing
> -------
> 
> - Testing done enabling the SOLR Plugin in ranger_audits collection.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message