ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 71473: RANGER-2567: Ranger fails to connect wired Solr
Date Fri, 13 Sep 2019 17:52:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71473/#review217729
-----------------------------------------------------------




embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 111 (patched)
<https://reviews.apache.org/r/71473/#comment305070>

    - call SSLContext.setDefault() only if "sslContext != null"
    - please review and update intentation in #110, #111



embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 487 (patched)
<https://reviews.apache.org/r/71473/#comment305071>

    It looks like any exception thrown from this method will cause Ranger Admin to abort startup.
Instead, I would suggest to log a WARN/ERROR message with failure details and have Ranger
Admin continue.



embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
Lines 504 (patched)
<https://reviews.apache.org/r/71473/#comment305072>

    Consider replacing "!StringUtil.isEmpty" with "StringUtil.isNotEmpty" - for better readability.


- Madhan Neethiraj


On Sept. 12, 2019, 11:33 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71473/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2019, 11:33 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja
Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2567
>     https://issues.apache.org/jira/browse/RANGER-2567
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> ** Problem Statement: ** Ranger fails to connect wired SSL through configured ranger
truststore file. Currently it works when solr certificate is added in jdk ca certs. Though
in the file PropertiesUtil.java, truststore related System properties has been provided its
not being considered probably Ranger's embeded tomcat server starts prior to load of Ranger's
truststore configs via PropertiesUtil.java.
> 
> ** Proposed Solution: ** Proposed patch contain changes in EmbeddedServer.java file so
that truststore related configs can be initialized prior to Ranger's embeded tomcat server
start.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java
b39212a79 
> 
> 
> Diff: https://reviews.apache.org/r/71473/diff/3/
> 
> 
> Testing
> -------
> 
> Without patch solr collection was failing and after the patch ranger is able to create
solr collection and ranger UI is able to fetch access audit records from solr.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message