ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 71569: RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation -part2
Date Wed, 02 Oct 2019 01:58:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71569/#review218013
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java
Lines 3401 (patched)
<https://reviews.apache.org/r/71569/#comment305476>

    This functions returns true when policy is null or there are no roles in the policy at
all. In those cases, there is no need to create an roleVersionUpdater. Please consider reversing
the logic (perhaps renaming the function isSomeRoleInPolicyNotPresentInAnyOtherPoliciesInService()
or something like that), that returns true only if some role in the policy is never before
seen in any other policy in the containing service.


- Abhay Kulkarni


On Oct. 2, 2019, 1:33 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71569/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2019, 1:33 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2512
>     https://issues.apache.org/jira/browse/RANGER-2512
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2512:RangerRolesRESTClient for serving user group roles to the plugins for evaluation
-part2
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
77648fd 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 9d26fb5 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 85db577 
>   security-admin/src/main/java/org/apache/ranger/db/XXGlobalStateDao.java d687e73 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 06a4063 
>   security-admin/src/main/java/org/apache/ranger/entity/XXServiceVersionInfo.java 1d81337

>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java d28cf3d 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml ab8e675 
> 
> 
> Diff: https://reviews.apache.org/r/71569/diff/1/
> 
> 
> Testing
> -------
> 
> - Addressed previous review comments
> - Addressed issue with Role download to the plugin when Roles are first create and added
to new or existing policy.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message