ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andor Molnar <an...@apache.org>
Subject Re: Review Request 71566: RANGER-2599. Add more audit data to HBase grant/revoke events
Date Fri, 04 Oct 2019 12:18:30 GMT


> On Oct. 2, 2019, 5:06 p.m., Velmurugan Periasamy wrote:
> > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
> > Lines 1500 (patched)
> > <https://reviews.apache.org/r/71566/diff/2/?file=2167718#file2167718line1500>
> >
> >     Getting compilation error. Please check. 
> >     
> >     ```
> >     [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile
(default-compile) on project ranger-hbase-plugin: Compilation failure: Compilation failure:
> >     [ERROR] /Workspace/git/tlp-ranger/master/ranger/hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java:[1500,21]
error: cannot find symbol
> >     [ERROR] symbol:   variable userPermission
> >     [ERROR] location: class RangerAuthorizationCoprocessor
> >     [ERROR] /Workspace/git/tlp-ranger/master/ranger/hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java:[1608,21]
error: cannot find symbol
> >     [ERROR] -> [Help 1]
> >     ```

Sorry, copy-paste error. Please re-check.


- Andor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71566/#review218023
-----------------------------------------------------------


On Oct. 4, 2019, 12:17 p.m., Andor Molnar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71566/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2019, 12:17 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently RangerAuthorizationCoprocessor correctly captures all data from HBase grant
and revoke events, but RangerBasePlugin only copies certain fields to RangerAccessEvent.
> 
> RequestData is one the fields which are copied to the final entity and currently not
being used by the co-processor. I'd like to add some missing information to this field and
make it available on the UI similarly how Hive queries are shown in a small pop-up.
> 
> First, I change the co-processor to populate RequestData with additional grant/revoke
information.
> 
> Second, I modify JS to show the RequestData pop-up on HBase audit events too.
> 
> https://issues.apache.org/jira/browse/RANGER-2599
> 
> 
> Diffs
> -----
> 
>   hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java
364a415943bed22890dc5773e162962bb30147f9 
>   security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 6ef33435af7e7cbed7fbc5dc4174c8fb46be3aaf

> 
> 
> Diff: https://reviews.apache.org/r/71566/diff/3/
> 
> 
> Testing
> -------
> 
> Tested on private test cluster.
> 
> 
> Thanks,
> 
> Andor Molnar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message