ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 71578: RANGER-2591 : Need changes for usersync(unix/ldap) to support HA without load balancer
Date Mon, 07 Oct 2019 14:46:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71578/#review218116
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java
Line 121 (original), 121 (patched)
<https://reviews.apache.org/r/71578/#comment305670>

    Patch fails to apply. Can you please check and rebase? 
    
    ```
    $ git apply --check -v /Users/vperiasamy/Downloads/4-RANGER-2591-Need-changes-for-usersync-unix-ldap-to-s.patch
    Checking patch agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java...
    error: while searching for:
    		mUrl               = url;
    		mSslConfigFileName = sslConfigFileName;
    		this.configuredURLs = getURLs(mUrl);
    		this.lastKnownActiveUrlIndex   = (new Random()).nextInt(configuredURLs.size());
    		init();
    	}
    
    error: patch failed: agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java:121
    error: agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java:
patch does not apply
    Checking patch ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java...
    Checking patch ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java...
    Checking patch ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java...
    ```


- Velmurugan Periasamy


On Oct. 3, 2019, 2:39 p.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71578/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2019, 2:39 p.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh,
Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2591
>     https://issues.apache.org/jira/browse/RANGER-2591
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Need changes for usersync(unix/ldap) to support HA without load balancer.
> - Ranger usersync should be able to sync users / groups when Ranger Admin is in HA (even
without having LB)
> - User needs to define Ranger URL values in comma separated format in 'ranger-ugsync-site.xml'
config file for 'ranger.usersync.policymanager.baseURL' name or property.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java ef5f1d5

>   ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapPolicyMgrUserGroupBuilder.java
224a600 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
52579a3 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/RangerUgSyncRESTClient.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71578/diff/2/
> 
> 
> Testing
> -------
> 
> ->BUILD SUCCESS
> 
> 1.User sync verified in simple, kerberose and SSL enabled environment.
> 2.Delta sync is verified for UNIX source.
> 3.Authentication is verified for UNIX source and LDAP source.
> 4.Checked user is able to login from both the Admin UI.
> 5.Checked Authentication after changing password of UNIX user.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message