ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 71626: RANGER-2510: Support for Incremental tag updates to improve performance
Date Wed, 16 Oct 2019 19:48:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71626/#review218239
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
Line 497 (original), 483 (patched)
<https://reviews.apache.org/r/71626/#comment305865>

    serviceResource might not have resourceDef.getName() - note that 'for' loop at #478 iterates
through all resources defined in the service-def. How is this handled?



agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
Lines 164 (patched)
<https://reviews.apache.org/r/71626/#comment305870>

    Perhaps this 'if' can be simplified with:
      if (evaluator.isAncestorOf(this.resourceDef))



agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
Line 434 (original), 441 (patched)
<https://reviews.apache.org/r/71626/#comment305868>

    Perhaps this 'if' can be simplified with:
      if (evaluator.isAncestorOf(resourceDef))


- Madhan Neethiraj


On Oct. 16, 2019, 7:20 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71626/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2019, 7:20 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2510
>     https://issues.apache.org/jira/browse/RANGER-2510
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Tags are not correctly propagated to descendant entity when tag-deltas are enabled. For
example, if a Hive database is tagged, then any Hive tables in that database also should be
tagged. This functionality is broken when tag-deltas are enabled.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerServiceResourceMatcher.java
f9bbb12b1 
>   agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
7434ec99f 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerZoneResourceMatcher.java
c7f5bc4b8 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java
4d6962fff 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerPolicyResourceEvaluator.java
7d43b4b8c 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java 0cba88232

>   agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java f383241f1

> 
> 
> Diff: https://reviews.apache.org/r/71626/diff/1/
> 
> 
> Testing
> -------
> 
> Tested with a cluster to ensure that tags are propagated correctly to descendant entities.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message