ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 71613: RANGER-2619 : Admin Audit Details not displayed for edit role.
Date Thu, 17 Oct 2019 13:24:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71613/#review218265
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On Oct. 16, 2019, 6:39 a.m., Mateen Mansoori wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71613/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2019, 6:39 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Nikhil P, and Pradeep Agrawal.
> 
> 
> Bugs: RANGER-2619
>     https://issues.apache.org/jira/browse/RANGER-2619
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> * When an existing role is edited by adding a new group or role or users, the details
are not displayed in the admin access details popup.
> 
> * Added changes to not generate logs when former and new values are same or both values
are empty.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java 17d74d5

>   security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java ce2dc35

> 
> 
> Diff: https://reviews.apache.org/r/71613/diff/2/
> 
> 
> Testing
> -------
> 
> -> BUILD SUCCESS ON LATEST APACHE MASTER
> -> Created role 'Dev_Role2' without adding any user, group and roles.
> 
> * Edited 'Dev_Role2' by adding user or role or groups.
> * Checked admin audit log generated as expected.
> 
> 
> Thanks,
> 
> Mateen Mansoori
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message