ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Luo <andrewluotechnolog...@outlook.com>
Subject Re: Review Request 71552: RANGER-2594: Improve policy validation performance during delete
Date Mon, 28 Oct 2019 06:35:27 GMT


> On Oct. 23, 2019, 3:39 p.m., Velmurugan Periasamy wrote:
> > Ship It!

Thanks for the review.  Can you perhaps help commit this change?  I am not a committer.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71552/#review218356
-----------------------------------------------------------


On Oct. 17, 2019, 7:25 a.m., Andrew Luo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71552/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2019, 7:25 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2594
>     https://issues.apache.org/jira/browse/RANGER-2594
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Deletion of large policies (those with several thousand users or resources) is slow -
one reason for this is that we fetch the entire policy during validation, when we only need
to check if the policy exists or not.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java
a85410782 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
f31483e97 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java ba7407fc4

>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 85db57719 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java 06a4063a6 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 9714fa91b 
> 
> 
> Diff: https://reviews.apache.org/r/71552/diff/3/
> 
> 
> Testing
> -------
> 
> Unit tests, and tested end-to-end
> 
> 
> Thanks,
> 
> Andrew Luo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message