ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 72307: RANGER-2775 : Pagination not working for role in Ranger admin UI page
Date Tue, 07 Apr 2020 21:17:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72307/#review220244
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On April 7, 2020, 2:09 p.m., Mahesh Bandal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72307/
> -----------------------------------------------------------
> 
> (Updated April 7, 2020, 2:09 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2775
>     https://issues.apache.org/jira/browse/RANGER-2775
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This issue occurs when we click on role tab in Ranger admin UI page. In response json
"startIndex","pageSize","totalCount","resultSize", "sortType", "sortBy" values were incorrect.
To solve this issue I have created a new method getRole which applies searchfilter on role
object and returns RangerRoleList response object with appropriate  values.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 9d2f0ba25 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java aa031ae65 
> 
> 
> Diff: https://reviews.apache.org/r/72307/diff/2/
> 
> 
> Testing
> -------
> 
> 1.  Created/Deleted multiple roles with/without assigning groups/users to it.
> 2.  All roles are divided equally on every page. Max 25 roles are present on each page.
> 
> 
> Thanks,
> 
> Mahesh Bandal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message