ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Review Request 72419: RANGER-2806: RangerScriptConditionEvaluator does not initialize correctly with openJDK 11
Date Wed, 22 Apr 2020 18:58:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72419/
-----------------------------------------------------------

Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan
Periasamy.


Bugs: RANGER-2806
    https://issues.apache.org/jira/browse/RANGER-2806


Repository: ranger


Description
-------

When using openJDK 11, RangerScriptConditionEvaluator object's init() method, when invoked
within the plugin, fails to create JavaScript engine required to evaluate policy conditions
with scripts. This failure causes any script-condition to evaluate to true (always).


Diffs
-----

  agents-common/pom.xml 44944f237 
  agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
8da42ba62 
  ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java
d4c3aed37 


Diff: https://reviews.apache.org/r/72419/diff/1/


Testing
-------

Passed all unit tests.
Tested with cluster running JVM (openjdk version "11.0.3" 2019-04-16 LTS
OpenJDK Runtime Environment Zulu11.31+11-CA (build 11.0.3+7-LTS)
OpenJDK 64-Bit Server VM Zulu11.31+11-CA (build 11.0.3+7-LTS, mixed mode)


Verified that RangerScriptConditionEvaluator found ScriptEngine for JavaScript.
Verified that tag policy with a policy condition that requires JavaScript ScriptEngine evaluated
the policy condition correctly.


Thanks,

Abhay Kulkarni


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message