ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 72455: RANGER-2814: RangerServiceResource signature should not include service-specific information
Date Thu, 30 Apr 2020 21:29:56 GMT


> On April 30, 2020, 7:59 p.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/patch/PatchForMigratingRangerServiceResource_J10037.java
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/72455/diff/1/?file=2229531#file2229531line130>
> >
> >     Instead of making a copy of the list, consider sending serviceResourceGuids,
fromIdx and chunkSize to TagsUpdaterThread() constructor:
> >       TagsUpdaterThread(txTemplate, serviceResourceGuids, chunkIndex * chunkSize,
chunkSize)

subList does not copy part of the list, but creates a view of the list. There is no performance
penalty involved here.


- Abhay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72455/#review220569
-----------------------------------------------------------


On April 30, 2020, 9:29 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72455/
> -----------------------------------------------------------
> 
> (Updated April 30, 2020, 9:29 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-2814
>     https://issues.apache.org/jira/browse/RANGER-2814
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RangerServiceResource objects represent a resource within scope of Ranger service in
Ranger world. For efficient searching, resource contains a signature (which is a digest of
its contents) which is computed at its creation as well as when it is updated. 
> 
> As the search for a resource is always carried out in the scope of Ranger service, there
is no need to include service name (or service id) in its signature. In fact,  having service
name included in the signature makes upgrade/migration of tagged service resources  very difficult.
> 
> Along with removing service-name from the signature of.a service resource, a patch to
migrate existing service resources to new signature is also needed.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/RangerServiceResourceSignature.java
eb9a9d240 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 320ab6d30 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql fbf91d861 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 74c7ffc76

>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 4715584d7

>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 1a966da0c

>   security-admin/src/main/java/org/apache/ranger/patch/PatchForMigratingRangerServiceResource_J10037.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72455/diff/2/
> 
> 
> Testing
> -------
> 
> Tested with ~100,000 service resources. Took about 3 minutes.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message