ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bolke de Bruin <bdbr...@gmail.com>
Subject Fwd: Re: Review Request 72272: Upgrade and improve Presto plugin
Date Tue, 21 Apr 2020 20:12:38 GMT
Hi Madhan,

Would you mind reviewing again?

If you know how to ‘fix’ the assembly to ensure everything is included
without putting it in the pom I will gladly do that.

Cheers
Bolke


On 21 April 2020 at 13:45:36, Bolke de Bruin (bdbruin@gmail.com) wrote:

This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72272/

On April 5th, 2020, 6:09 p.m. UTC, *Madhan Neethiraj* wrote:

agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json
<https://reviews.apache.org/r/72272/diff/2/?file=2215810#file2215810line96>
(Diff
revision 2)

96

    },

To update existing Ranger instances with these service-def changes,
consider adding a Java patch similar to
PatchForAtlasToAddEntityLabelAndBusinessMetadata_J10034.java that
handles recent updates to Atlas service-def.

This can be taken up in a subsequent commit.

On April 15th, 2020, 3:04 p.m. UTC, *Pradeep Agrawal* wrote:

Created RANGER-2795 to track this separately.

Thx. Will pick it up after merging this.


On April 5th, 2020, 6:09 p.m. UTC, *Madhan Neethiraj* wrote:

ranger-presto-plugin-shim/pom.xml
<https://reviews.apache.org/r/72272/diff/2/?file=2215820#file2215820line93>
(Diff
revision 2)

93

            <groupId>org.apache.hadoop</groupId>

The changes in this module don't seem to refer hadoop-hdfs library
contents directly. Is it necessary to explicitly add this dependency?

On April 10th, 2020, 8:53 a.m. UTC, *Bolke de Bruin* wrote:

I'm not getting it into the assembly otherwise for auditing purposes?
please advise.

On April 15th, 2020, 3:04 p.m. UTC, *Pradeep Agrawal* wrote:

try adding in https://github.com/apache/ranger/blob/master/distro/src/main/assembly/plugin-presto.xml
make sure you are adding in the directory where you want it.

That's what I did. The items are not picked up if the dependency is
not present in the pom?


On April 5th, 2020, 6:09 p.m. UTC, *Madhan Neethiraj* wrote:

ranger-presto-plugin-shim/pom.xml
<https://reviews.apache.org/r/72272/diff/2/?file=2215820#file2215820line134>
(Diff
revision 2)

134

        <dependency>

The changes in this module don't seem to refer protobuf-java library
contents directly. Is it necessary to explicitly add this dependency?

On April 10th, 2020, 8:53 a.m. UTC, *Bolke de Bruin* wrote:

Idem as above. How to get it in the assembly? It seems not to be
included otherwise (struggling with that overall btw)

On April 15th, 2020, 3:04 p.m. UTC, *Pradeep Agrawal* wrote:

try adding in https://github.com/apache/ranger/blob/master/distro/src/main/assembly/plugin-presto.xml
make sure you are adding in the directory where you want it.

Idem as above.


- Bolke

On April 21st, 2020, 11:43 a.m. UTC, Bolke de Bruin wrote:
Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal,
and Ramesh Mani.
By Bolke de Bruin.

*Updated April 21, 2020, 11:43 a.m.*
*Bugs: * https://issues.apache.org/jira/browse/RANGER-2754
<https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2754>
*Repository: * ranger
Description

Upgrade and improve Presto plugin
- Presto SQL 331 has changed its security API and has Row level /
column masking functionality
- Upgraded Hadoop dependency to 3.1.3 (from 3.1.1) due to improved
security handling
- New features like session properties and system properties

Testing


   - New Unit tests added
   - Tested locally in production

Diffs

   - agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json
   (56a8f5ac0)
   - distro/src/main/assembly/plugin-presto.xml (d2075bfe7)
   - plugin-presto/pom.xml (b63f7dede)
   - plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
   (3ab63f590)
   - plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerAdminClientImpl.java
   (PRE-CREATION)
   - plugin-presto/src/test/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlTest.java
   (PRE-CREATION)
   - plugin-presto/src/test/resources/log4j.properties (PRE-CREATION)
   - plugin-presto/src/test/resources/presto-policies.json (PRE-CREATION)
   - plugin-presto/src/test/resources/ranger-presto-security.xml
   (PRE-CREATION)
   - pom.xml (992c3654e)
   - ranger-presto-plugin-shim/pom.xml (d8ff88d0f)
   - ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java
   (67b0d2434)
   - ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java
   (e89f646e1)

View Diff <https://reviews.apache.org/r/72272/diff/10/>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message