ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhavik patel <bhavikpatel...@gmail.com>
Subject Re: Review Request 72662: RANGER-2903: Remove elasticsearch audit's is_enabled property from config
Date Fri, 10 Jul 2020 11:15:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72662/#review221181
-----------------------------------------------------------


Ship it!




Ship It!

- bhavik patel


On July 8, 2020, 11:43 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72662/
> -----------------------------------------------------------
> 
> (Updated July 8, 2020, 11:43 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2903
>     https://issues.apache.org/jira/browse/RANGER-2903
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem Statement:**
> Ranger plugin's ranger-$plugin-audit-changes.cfg file is having an old audit v2 config
entry which is:
> 
> xasecure.audit.elasticsearch.is.enabled             %XAAUDIT.ELASTICSEARCH.IS_ENABLED%
                              mod create-if-not-exists
> 
> The above config is not required as elasticsearch audit is now only supported in V3,
and v2 support was not implemented.
> 
> The above config must be removed else plugin setup will fail as it will not find the
"XAAUDIT.ELASTICSEARCH.IS_ENABLED" property in corresponding plugin's install.properties file.
>  
> 
> **Proposed solution:** The above problem can be solved with two approaches. Proposed
patch having changes according to solution-2 mentioned below.
> 
> Solution-1: Add the "XAAUDIT.ELASTICSEARCH.IS_ENABLED" property in all plugin's install.properties
file.
> Solution-2: Remove the config from ranger-$plugin-audit-changes.cfg files and ranger-$plugin-audit.xml
file.
> 
> 
> **Note:** Proposed patch also contain changes related to moving of log4j audit properties
to right location in the same file for better readability and maintenance.
> 
> 
> Diffs
> -----
> 
>   agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java
8ee84ac4c 
>   hbase-agent/conf/ranger-hbase-audit-changes.cfg 19425ff4a 
>   hbase-agent/conf/ranger-hbase-audit.xml f558ee617 
>   hbase-agent/scripts/install.properties 1329f3774 
>   hdfs-agent/conf/ranger-hdfs-audit-changes.cfg 762419b18 
>   hdfs-agent/conf/ranger-hdfs-audit.xml 5e352595f 
>   hdfs-agent/scripts/install.properties 6a17bd283 
>   hive-agent/conf/ranger-hive-audit-changes.cfg a22592955 
>   hive-agent/conf/ranger-hive-audit.xml 2ea8ef67a 
>   hive-agent/scripts/install.properties 8fb2046c2 
>   kms/scripts/install.properties 979f64612 
>   knox-agent/conf/ranger-knox-audit-changes.cfg f125a8e48 
>   knox-agent/conf/ranger-knox-audit.xml 537a226ad 
>   knox-agent/scripts/install.properties 09e87f15e 
>   plugin-atlas/conf/ranger-atlas-audit.xml 9f032272a 
>   plugin-atlas/scripts/install.properties aa128a1d5 
>   plugin-elasticsearch/conf/ranger-elasticsearch-audit-changes.cfg 8d3533689 
>   plugin-elasticsearch/conf/ranger-elasticsearch-audit.xml e9934ff4a 
>   plugin-elasticsearch/scripts/install.properties f2b6cadb3 
>   plugin-kafka/conf/ranger-kafka-audit-changes.cfg 9525b61ed 
>   plugin-kafka/conf/ranger-kafka-audit.xml 93b0fc5b7 
>   plugin-kafka/scripts/install.properties f27e0f79e 
>   plugin-kms/conf/ranger-kms-audit-changes.cfg a5a669f3c 
>   plugin-kms/conf/ranger-kms-audit.xml d1a99f7e3 
>   plugin-kylin/conf/ranger-kylin-audit-changes.cfg 8d3533689 
>   plugin-kylin/conf/ranger-kylin-audit.xml b977bc595 
>   plugin-kylin/scripts/install.properties 6db3da36f 
>   plugin-ozone/conf/ranger-ozone-audit-changes.cfg e4a7e3066 
>   plugin-ozone/conf/ranger-ozone-audit.xml 1808f3770 
>   plugin-ozone/scripts/install.properties 8f4f8afd3 
>   plugin-presto/conf/ranger-presto-audit-changes.cfg 9525b61ed 
>   plugin-presto/conf/ranger-presto-audit.xml 6985f923d 
>   plugin-presto/scripts/install.properties 1eddd21ab 
>   plugin-solr/conf/ranger-solr-audit-changes.cfg 6c7c9ce13 
>   plugin-solr/conf/ranger-solr-audit.xml aa10e3450 
>   plugin-solr/scripts/install.properties b684ef2d7 
>   plugin-sqoop/conf/ranger-sqoop-audit-changes.cfg 8d3533689 
>   plugin-sqoop/conf/ranger-sqoop-audit.xml a84514f8a 
>   plugin-sqoop/scripts/install.properties 51e8ad4f7 
>   plugin-yarn/conf/ranger-yarn-audit-changes.cfg 8d3533689 
>   plugin-yarn/conf/ranger-yarn-audit.xml 1a49e9e39 
>   plugin-yarn/scripts/install.properties 0a4dd97e2 
>   storm-agent/conf/ranger-storm-audit-changes.cfg 8d3533689 
>   storm-agent/conf/ranger-storm-audit.xml 77c71d6cd 
>   storm-agent/scripts/install.properties 8834ebc60 
> 
> 
> Diff: https://reviews.apache.org/r/72662/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message