ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 72699: RANGER-2921: Regression: When all resource and tag(if applicable) policies are deleted then plugin continues to use old set of policies
Date Tue, 21 Jul 2020 19:44:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72699/#review221293
-----------------------------------------------------------


Fix it, then Ship it!





agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
Line 208 (original), 208 (patched)
<https://reviews.apache.org/r/72699/#comment310173>

    Minor typo "Downloade"


- Velmurugan Periasamy


On July 21, 2020, 6:30 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72699/
> -----------------------------------------------------------
> 
> (Updated July 21, 2020, 6:30 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2921
>     https://issues.apache.org/jira/browse/RANGER-2921
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> All policies in a service (including tag policies if the service has associated tag-service)
are removed. Plugin downloads this change correctly, however, it continues to execute old
set of policies. Effectively, this change in policies is ignored, until another policy is
created for this service (or in associated tag service).
> 
> The root cause is that the check for ensuring that the downloaded policies are internally
consistent was incorrectly done.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
d860f3c62 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java
241cf9d63 
> 
> 
> Diff: https://reviews.apache.org/r/72699/diff/1/
> 
> 
> Testing
> -------
> 
> Ran all unit test cases successfully.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message