ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 72696: RANGER-2919 : Source policies gets deleted after importing policy with deleteifexists parameter
Date Tue, 21 Jul 2020 23:26:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72696/#review221301
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 2320 (patched)
<https://reviews.apache.org/r/72696/#comment310180>

    line #2325 is called with policies that belong to services that are in the destinationServices
(the policies that are added to existingTargetPolicies in line #2320).



security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
Lines 2325 (patched)
<https://reviews.apache.org/r/72696/#comment310181>

    Problem: if deleteIfExists parameter is set to 'true' then the policies selected for copying
over to destination service are deleted from source service.


- Abhay Kulkarni


On July 21, 2020, 1:28 p.m., Dineshkumar Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72696/
> -----------------------------------------------------------
> 
> (Updated July 21, 2020, 1:28 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Gautam Borad, Kishor Gollapalliwar, Abhay Kulkarni,
Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> source policy is getting deleted while importing policy with deleteifexists parameter
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c795525f2 
> 
> 
> Diff: https://reviews.apache.org/r/72696/diff/1/
> 
> 
> Testing
> -------
> 
> Steps to Reproduce: 
> 1. Create 2 Hbase service i.e. hbase1 and hbase2, 
> 2. Create some policies in service - hbase1
> 3. perform policy import from source service - hbase1 to target service - hbase2
> 4. Policies from service - hbase1 gets successfully imported to service - hbase2 as per
deleteifexist parameter feature
> 5. After import, Policies from source service - hbase1 also gets deleted
> 
> After patch source service is not getting deleted.
> 
> 
> Thanks,
> 
> Dineshkumar Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message