ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sailaja Polavarapu <spolavar...@hortonworks.com>
Subject Re: Review Request 72717: RANGER-2931: Fix PMD Error of RANGER-2922
Date Thu, 30 Jul 2020 00:12:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72717/#review221414
-----------------------------------------------------------


Ship it!




Ship It!

- Sailaja Polavarapu


On July 29, 2020, 6:19 a.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72717/
> -----------------------------------------------------------
> 
> (Updated July 29, 2020, 6:19 a.m.)
> 
> 
> Review request for ranger and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2931
>     https://issues.apache.org/jira/browse/RANGER-2931
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> **Problem statement:** RANGER-2922 commit has one empty if statement which is giving
a PMD error message.
> 
> **Proposed solution:** Patch shall add throw statement inside of the if statement.
> Solution is inspired from the same file line#727
> https://github.com/apache/ranger/blame/master/plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java#L727
> 
> 
> Diffs
> -----
> 
>   plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
d7ac11934 
> 
> 
> Diff: https://reviews.apache.org/r/72717/diff/1/
> 
> 
> Testing
> -------
> 
> Build is working fine and not throwing any pmd error.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message