ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Shukla via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 72837: RANGER-2985, RANGER-2845, and RAGNER-2848: Update ozone service Def, added upgrade patch, and updated ozone plugin pom file to use version from main pom
Date Sat, 05 Sep 2020 09:43:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72837/#review221809
-----------------------------------------------------------




agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json
Line 20 (original), 20 (patched)
<https://reviews.apache.org/r/72837/#comment310894>

    Can excludesSupported be set to true for volume?



agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json
Lines 84-85 (patched)
<https://reviews.apache.org/r/72837/#comment310895>

    Indentation not correct.



plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java
Lines 127-128 (patched)
<https://reviews.apache.org/r/72837/#comment310896>

    Indentation not correct.


- Abhishek Shukla


On Sept. 4, 2020, 10 p.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72837/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2020, 10 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and Velmurugan
Periasamy.
> 
> 
> Bugs: RANGER-2845, RANGER-2848 and RANGER-2985
>     https://issues.apache.org/jira/browse/RANGER-2845
>     https://issues.apache.org/jira/browse/RANGER-2848
>     https://issues.apache.org/jira/browse/RANGER-2985
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added read-acl & write-acl access types to ozone service def in order to fix RANGER-2985.
Also, cleaned up unused configs in ozone service def and marked recursive supported flag to
"false" for Volume resource and "true" for key resource. Added upgrade patch to handle service
def changes and update existing policies for ozone.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json 4f2a43284

>   distro/src/main/assembly/plugin-ozone.xml fb4cdd11e 
>   plugin-ozone/pom.xml a310560d9 
>   plugin-ozone/src/main/java/org/apache/ranger/authorization/ozone/authorizer/RangerOzoneAuthorizer.java
46b99321d 
>   plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java
e16b5db6a 
>   ranger-ozone-plugin-shim/pom.xml 1d66fdadb 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 3320fc232 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 698a68705 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql edccc0a7d

>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 1ffbc6ca0

>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql 957f9249e

>   security-admin/src/main/java/org/apache/ranger/patch/PatchForOzoneServiceDefUpdate_J10041.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72837/diff/1/
> 
> 
> Testing
> -------
> 
> 1. Patched a cluster with the changes and updated service def with new changes.
> 2. Verified functionality like create volume and update volume with new changes.
> 3. Also verified creating new ozone policies with the latest changes.
> 4. Tested same functionality with upgrade patch as well.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message