ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dhaval Shah <dhavalshah9...@gmail.com>
Subject Re: Review Request 72889: RANGER-3005: repoType and repo values does not set when Audit to Elasticsearch is enabled
Date Mon, 21 Sep 2020 06:38:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72889/#review221908
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 194 (patched)
<https://reviews.apache.org/r/72889/#comment310959>

    Please add null and empty check for xxService.getDisplayName().



security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
Lines 239 (patched)
<https://reviews.apache.org/r/72889/#comment310960>

    Please add null and empty check for xServiceDef.getDisplayName()


- Dhaval Shah


On Sept. 21, 2020, 6:05 a.m., bhavik patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72889/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2020, 6:05 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Dhaval Shah, Gautam Borad, Abhay Kulkarni, Madhan
Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3005
>     https://issues.apache.org/jira/browse/RANGER-3005
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> When Audit to Elasticsearch is enabled then in Audit => Access tab "repo/repoType"
column is empty.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/elasticsearch/ElasticSearchAccessAuditsService.java
f28eb248f 
> 
> 
> Diff: https://reviews.apache.org/r/72889/diff/1/
> 
> 
> Testing
> -------
> 
> Already using in Production environment.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message