ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 73001: RANGER-3068: Ranger Usersync is not handling error during initialization process
Date Tue, 03 Nov 2020 00:56:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73001/#review222160
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 328 (original), 329 (patched)
<https://reviews.apache.org/r/73001/#comment311229>

    Please check the message for spellings



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 367 (patched)
<https://reviews.apache.org/r/73001/#comment311230>

    Please see if this can be changed to 
    
    throw e;
    
    here and other places in the code.



ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Lines 808 (patched)
<https://reviews.apache.org/r/73001/#comment311231>

    Please print the exception in the error message such as
    
    LOG.error("Failed to addOrUpdateUsers " + uploadedCount, e);
    
    Here and elsewhere in the code.


- Abhay Kulkarni


On Nov. 3, 2020, 12:03 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73001/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2020, 12:03 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Mehul Parikh, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3068
>     https://issues.apache.org/jira/browse/RANGER-3068
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added code to handle error during initialization as well as while updating users, group,
and memberships to ranger admin
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
6a4661e60 
> 
> 
> Diff: https://reviews.apache.org/r/73001/diff/1/
> 
> 
> Testing
> -------
> 
> Patched changes to a cluster and tested error conditions.
> Also tested basic regression cases.
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message