ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ramesh Mani <rm...@hortonworks.com>
Subject Re: Review Request 72969: RANGER-3000:Audit-filter feature implementation to help reduce volume of audit logs generated
Date Mon, 30 Nov 2020 06:37:17 GMT


> On Nov. 30, 2020, 4 a.m., Don Bosco Durai wrote:
> > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java
> > Lines 128 (patched)
> > <https://reviews.apache.org/r/72969/diff/4/?file=2242444#file2242444line128>
> >
> >     We are returning null. I assume we are handling it where it is been called.
Should we just throw the exception and let it get handle where it is called?

Bosco, when auditFilters are null, resulting auditPolicyEvaluators are going to be Empty and
won't get evaluated. Existing auditing decision by the resource / tag policies will be the
one used.


- Ramesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72969/#review222247
-----------------------------------------------------------


On Nov. 30, 2020, 6:21 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72969/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2020, 6:21 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3000
>     https://issues.apache.org/jira/browse/RANGER-3000
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3000:Audit-filter feature implementation to help reduce volume of audit logs generated
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java 994d3944d

>   agents-common/src/main/java/org/apache/ranger/plugin/model/AuditFilter.java PRE-CREATION

>   agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java 04c6e75c4

>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java
0d9a346d4 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
c54ef1704 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
4e41adcea 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
b66d5a1ce 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
169ed0f5d 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java
PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
07fb63872 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java
979488181 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
2d9bc7382 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java 6ab068f6f

>   agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
63fccd0b3 
>   agents-common/src/test/resources/policyengine/test_policyengine_audit_filter_hdfs.json
PRE-CREATION 
>   agents-common/src/test/resources/policyengine/test_policyengine_audit_filter_hive.json
PRE-CREATION 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 520258715 
> 
> 
> Diff: https://reviews.apache.org/r/72969/diff/6/
> 
> 
> Testing
> -------
> 
> - Testing done in local VM.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message