ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 73051: RANGER-3070: Added Support for using {OWNER} placeholder in Ozone plugin default policies and upgrade patch
Date Tue, 01 Dec 2020 01:07:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73051/#review222253
-----------------------------------------------------------




plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java
Line 119 (original), 120 (patched)
<https://reviews.apache.org/r/73051/#comment311322>

    Instead of 'contains', consider looking for policies having name that start with 'all
- '. Please refer to RangerBaseService.buildPolicyName().



security-admin/src/main/java/org/apache/ranger/patch/PatchForOzoneDefaultPoliciesUpdate_J10044.java
Lines 113 (patched)
<https://reviews.apache.org/r/73051/#comment311323>

    Instead of 'contains', consider looking for policies having name that start with 'all
- '. Please refer to RangerBaseService.buildPolicyName().


- Madhan Neethiraj


On Dec. 1, 2020, 12:46 a.m., Sailaja Polavarapu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73051/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2020, 12:46 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3070
>     https://issues.apache.org/jira/browse/RANGER-3070
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Added Owner variable for default policies for ozone plugin as well as upgrade patch.
Thia patch doesn't include plugin side change to retrive owner information from the request
context. Once the Ozone API is available, will update the ozone plugin accordingly.
> 
> 
> Diffs
> -----
> 
>   plugin-ozone/src/main/java/org/apache/ranger/services/ozone/RangerServiceOzone.java
d8fb3171d 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql ad85e4536 
>   security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 77f25686e 
>   security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 91b85a30c

>   security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 9e07ef1a0

>   security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql d8a8c08ad

>   security-admin/src/main/java/org/apache/ranger/patch/PatchForOzoneDefaultPoliciesUpdate_J10044.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73051/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sailaja Polavarapu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message