ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 73333: RANGER-3253: Make incremental policy change computation more resilient - Part 2
Date Wed, 05 May 2021 00:30:24 GMT


> On May 5, 2021, 12:03 a.m., Sailaja Polavarapu wrote:
> > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java
> > Line 128 (original), 128 (patched)
> > <https://reviews.apache.org/r/73333/diff/1/?file=2249774#file2249774line128>
> >
> >     Just want to check if we want to Log policies at the warning level.

As this is an unusual and rare situation, it may be better to get the dump of policies that
caused the condition.


- Abhay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73333/#review222947
-----------------------------------------------------------


On May 4, 2021, 11:42 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73333/
> -----------------------------------------------------------
> 
> (Updated May 4, 2021, 11:42 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, and Velmurugan
Periasamy.
> 
> 
> Bugs: RANGER-3253
>     https://issues.apache.org/jira/browse/RANGER-3253
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Improved log messages. Suppressed spurious rebuilding of policy-engine if no NET change
to service policies.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
15b8fc76f 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
a7c4c97a1 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java
7088e8365 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminCache.java 120a32918

>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 477129d09

> 
> 
> Diff: https://reviews.apache.org/r/73333/diff/1/
> 
> 
> Testing
> -------
> 
> Passed all unit tests.
> 
> Used python client to create/update/delete Hive policies in a loop and ensured that incremental
policy download requests at random intervals are processed correctly. Also ensured that unusual
conditions emit warning messages both in Ranger-Admin and in the plugin.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message