ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chia-Ping Tsai <chia7...@gmail.com>
Subject Review Request 73336: RANGER-3276 Remove duplicate code from buildks.java
Date Wed, 05 May 2021 18:24:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73336/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-3276
    https://issues.apache.org/jira/browse/RANGER-3276


Repository: ranger


Description
-------

the duplicate code are shown below.

1. 
https://github.com/apache/ranger/blob/release-ranger-2.1.0/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java#L317

2.
https://github.com/apache/ranger/blob/release-ranger-2.1.0/credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java#L324


Diffs
-----

  credentialbuilder/src/main/java/org/apache/ranger/credentialapi/buildks.java 5d196d972 


Diff: https://reviews.apache.org/r/73336/diff/1/


Testing
-------

run `mvn clean test` on my local. all tests pass


Thanks,

Chia-Ping Tsai


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message