ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Velmurugan Periasamy <vperias...@hortonworks.com>
Subject Re: Review Request 73363: RANGER-3291: NPE in BasePlugin if the first policy download contains no policies and no policy-deltas
Date Thu, 20 May 2021 20:52:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73363/#review223018
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 20, 2021, 8:23 p.m., Abhay Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73363/
> -----------------------------------------------------------
> 
> (Updated May 20, 2021, 8:23 p.m.)
> 
> 
> Review request for ranger, Madhan Neethiraj, Mahesh Bandal, Ramesh Mani, Sailaja Polavarapu,
and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3291
>     https://issues.apache.org/jira/browse/RANGER-3291
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This issue is seen only if incremental policy downloads are enabled. If the first ever
policy download request made by the service returns no policies or policy-deltas (because
ranger repository does not contain any policies), then the policy-engine's value remains null.
This causes any subsequent incremental downloads to fail with NPE.
> 
> The fix is if the policy-engine does not require any update after policy download, then
ensure that it is initialized with default-service-policies.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
0aab80945 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 2369f4193 
> 
> 
> Diff: https://reviews.apache.org/r/73363/diff/1/
> 
> 
> Testing
> -------
> 
> Passes all unit tests.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message