ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 73365: RANGER-3292 Fix ConcurrentModificationException from RangerTransactionSynchronizationAdapter
Date Fri, 21 May 2021 13:46:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73365/#review223031
-----------------------------------------------------------




security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
Lines 157 (patched)
<https://reviews.apache.org/r/73365/#comment312188>

    Please consider providing a unit test (or documentation) showing/describing how this issue
can be reproduced without the patch.


- Abhay Kulkarni


On May 21, 2021, 11:36 a.m., Chia-Ping Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73365/
> -----------------------------------------------------------
> 
> (Updated May 21, 2021, 11:36 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3292
>     https://issues.apache.org/jira/browse/RANGER-3292
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The root cause is `runnables` get increased when runnable is executing. It can be fixed
by using index instead of foreach.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
7349898e7 
> 
> 
> Diff: https://reviews.apache.org/r/73365/diff/1/
> 
> 
> Testing
> -------
> 
> `mvn clean test` pass on my local and the error does not appear on my local.
> 
> 
> Thanks,
> 
> Chia-Ping Tsai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message