ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Madhan Neethiraj <mad...@apache.org>
Subject Re: Review Request 73367: RANGER-3294:AccessResult attribute with isAudited as false not filtered in Ranger Audit Filter
Date Mon, 24 May 2021 19:00:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73367/#review223035
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java
Line 244 (original), 244 (patched)
<https://reviews.apache.org/r/73367/#comment312196>

    Would n't this cause DENY filter to trigger when access result is 'not determined'? This
can result in incorrect audit-filter, for example in few services like HDFS/YARN, fallback
authorization can allow the access. Please review.


- Madhan Neethiraj


On May 21, 2021, 5:57 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73367/
> -----------------------------------------------------------
> 
> (Updated May 21, 2021, 5:57 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh,
Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3294
>     https://issues.apache.org/jira/browse/RANGER-3294
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3294:AccessResult attribute with isAudited as false not filtered in Ranger Audit
Filter
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAuditPolicyEvaluator.java
108856fcf 
> 
> 
> Diff: https://reviews.apache.org/r/73367/diff/1/
> 
> 
> Testing
> -------
> 
> Verified in local VM for audit filter to filter out Allow and deny request in Hive.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message