ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chia-Ping Tsai <chia7...@gmail.com>
Subject Re: Review Request 73365: RANGER-3292 Fix ConcurrentModificationException from RangerTransactionSynchronizationAdapter
Date Wed, 26 May 2021 11:25:40 GMT


> On 五月 26, 2021, 3:15 a.m., Wei-Chiu Chuang wrote:
> > Better to use Collections.unModifiableList() instead.

that is a good suggestion. However, I try to keep this patch small. Maybe we can address it
in separate PR.


- Chia-Ping


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73365/#review223046
-----------------------------------------------------------


On 五月 26, 2021, 11:24 a.m., Chia-Ping Tsai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73365/
> -----------------------------------------------------------
> 
> (Updated 五月 26, 2021, 11:24 a.m.)
> 
> 
> Review request for ranger and Abhay Kulkarni.
> 
> 
> Bugs: RANGER-3292
>     https://issues.apache.org/jira/browse/RANGER-3292
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The root cause is `runnables` get increased when runnable is executing. It can be fixed
by using index instead of foreach.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java
7349898e7 
>   security-admin/src/test/java/org/apache/ranger/common/db/TestRangerTransactionSynchronizationAdapter.java
PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73365/diff/2/
> 
> 
> Testing
> -------
> 
> `mvn clean test` pass on my local and the error does not appear on my local.
> 
> 
> Thanks,
> 
> Chia-Ping Tsai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message