ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhay Kulkarni <akulka...@hortonworks.com>
Subject Re: Review Request 73444: RANGER-3332: script evaluator updated to provide JavaScript style access to details of request/user/groups/tags
Date Tue, 13 Jul 2021 00:54:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73444/#review223215
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
Lines 97 (patched)
<https://reviews.apache.org/r/73444/#comment312314>

    Please consider measuring time spent in this method (and in Json.parse()) using perf logging
- as for every script evaluation, both toJson and Json.parse() will be called.



agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
Lines 176 (patched)
<https://reviews.apache.org/r/73444/#comment312313>

    Please ensure that com.google.gson.Gsoncom.google.gson.Gson 
    (used by JsonUtil class as a static singleton) is thread-safe.


- Abhay Kulkarni


On July 8, 2021, 10:59 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73444/
> -----------------------------------------------------------
> 
> (Updated July 8, 2021, 10:59 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Pradeep Agrawal,
Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3332
>     https://issues.apache.org/jira/browse/RANGER-3332
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Updated script condition evaluator to support JavaScript style access to request/user/groups/tags
detail. For example:
>  - _ctx.request.clusterType == 'azure'
>  - _ctx.tag.type == 'PII' && _ctx.userAttributes.dept == 'hr'
>  - _ctx.tag.attributes.pii_type = 'email'
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java
b306f5150 
>   agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
c0a8f9f35 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java
ed2dffd91 
>   agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerCustomConditionMatcherTest.java
0a4dd4a02 
> 
> 
> Diff: https://reviews.apache.org/r/73444/diff/1/
> 
> 
> Testing
> -------
> 
> - added unit tests
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message