ranger-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pradeep Agrawal <pradeepagrawal8...@gmail.com>
Subject Re: Review Request 73460: RANGER-3341: External user's role creation may fail in certain version of MariaDB
Date Thu, 15 Jul 2021 17:51:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73460/
-----------------------------------------------------------

(Updated July 15, 2021, 5:51 p.m.)


Review request for ranger, Dhaval Shah, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh
Mani, Sailaja Polavarapu, Vishal Suvagia, and Velmurugan Periasamy.


Changes
-------

Updated testcases.


Bugs: RANGER-3341
    https://issues.apache.org/jira/browse/RANGER-3341


Repository: ranger


Description
-------

**Problem Statement:** During policy import on maria DB flavor it was observed that when policy
user is created, return object of XXPortalUser does not have the generated unique id of the
user, hence null value was assigned. null user id can't be used for entries in x_portal_user_role
table for the same user. 


**Proposed Solution:** once a XXPortalUser entry is created, a fresh call need to made to
fetch the same user details and if it has the generated unique id then that id can be used
for creating the roles of the same user.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java 6483bbe1d 
  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 318c4ee0f 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 24cb43e54 
  security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java 202a113d8 


Diff: https://reviews.apache.org/r/73460/diff/3/

Changes: https://reviews.apache.org/r/73460/diff/2-3/


Testing (updated)
-------

Tested the patch in MariaDB(10.3) and postgres DB(10.15) and issue is not reproducible.


Note: Kafka test cases failing with and without patch in my env. need to recheck in other
env.


Thanks,

Pradeep Agrawal


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message