rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ankur Goyal" <asgo...@indiana.edu>
Subject Re: Review Request: Rave-357: Use display name instead of username in home page greeting
Date Wed, 16 Nov 2011 21:20:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2866/
-----------------------------------------------------------

(Updated 2011-11-16 21:20:18.998438)


Review request for rave and Marlon Pierce.


Changes
-------

Changes made in files:
User.java (added getter and setter for display name. May be not needed)
Person.java (provided length = 255 for displayName property)
initial_data.sql (added display_name value for test users)


Summary
-------

Now that User extends Person we have a field for displayname. If this field is populated it
should be used for the user's greeting on the homepage (the username can be an externally
generated value). 
Also let the rave-extension-sso populate the displayname.


Diffs
-----

  trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java 1202882

  trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java 1202882

  trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1202882 
  trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/home.jsp 1202882 

Diff: https://reviews.apache.org/r/2866/diff


Testing
-------


Thanks,

Ankur


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message