rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jasha Joachimsthal" <ja...@apache.org>
Subject Re: Review Request: Rave-357: Use display name instead of username in home page greeting
Date Tue, 22 Nov 2011 08:18:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2866/#review3428
-----------------------------------------------------------

Ship it!


Applied the patch (except for the getter/setter in User. Added fallback to username in the
home.jsp if displayname is empty


trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java
<https://reviews.apache.org/r/2866/#comment7670>

    Getters and setters for displayname are not necessary because they are already present
in Person


- Jasha


On 2011-11-16 21:20:18, Ankur Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2866/
> -----------------------------------------------------------
> 
> (Updated 2011-11-16 21:20:18)
> 
> 
> Review request for rave and Marlon Pierce.
> 
> 
> Summary
> -------
> 
> Now that User extends Person we have a field for displayname. If this field is populated
it should be used for the user's greeting on the homepage (the username can be an externally
generated value). 
> Also let the rave-extension-sso populate the displayname.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/Person.java
1202882 
>   trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/User.java
1202882 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1202882 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/home.jsp 1202882 
> 
> Diff: https://reviews.apache.org/r/2866/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ankur
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message