rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ciancetta, Jesse E." <jc...@mitre.org>
Subject RE: [discuss] Apache Rave 0.5-incubating Release Candidate
Date Tue, 01 Nov 2011 15:07:15 GMT
>> The error is occurring because: 1) DefaultWidgetService.registerNewWidget
>> returns a null Widget if the url already exists, and 2) the
>> RavePermissionEvaluator.hasPermission functions need to handle null
>> better.  I'll create a bug ticket for this issue.
>I wrote the 1) logic but now I see it back I see room for improvement. The
>Validator can reject the new widget if its url is already present. Then if
>for some reason DefaultWidgetService#registerNewWidget is called for a URL
>that already exists, it can throw a (DuplicateItem)Exception instead of
>returning null. WDYT?

+1 -- sounds good to me.


View raw message