rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfrank...@apache.org
Subject Re: Review Request: Rave 547, 549, 550
Date Mon, 16 Apr 2012 19:31:12 GMT


> On 2012-04-16 19:18:43, Jasha Joachimsthal wrote:
> > trunk/rave-portal-resources/src/main/webapp/script/rave.js, line 436
> > <https://reviews.apache.org/r/4739/diff/1/?file=102150#file102150line436>
> >
> >     We had some issues with console.log before if there was no console for that
browser. Can you please remove it?

Please use rave.log instead.  It checks for console and can be overridden by developers to
do whatever you want from a common logging facility.


> On 2012-04-16 19:18:43, Jasha Joachimsthal wrote:
> > trunk/rave-portal-resources/src/main/webapp/script/rave.js, line 63
> > <https://reviews.apache.org/r/4739/diff/1/?file=102150#file102150line63>
> >
> >     Please solve the TODO :)

We are moving to bootstrap (being worked in a branch.  These styles and the markup will need
to change.  IMO, it would be best for you to remove the TODO and create a subtask for RAVE-477
to update this code before merging into trunk.


- mfranklin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4739/#review6944
-----------------------------------------------------------


On 2012-04-16 18:41:14, Erin Noe-Payne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4739/
> -----------------------------------------------------------
> 
> (Updated 2012-04-16 18:41:14)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> Rave 547, 549, 550
> 
> Implement container.views.createElementForGadget to support gadgets.views.openGadget,
supporting slideout, modal, and dialog popups.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml PRE-CREATION 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1326730 
>   trunk/rave-portal-resources/src/main/webapp/script/rave.js 1326730 
>   trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1326730 
>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java
1326730 
> 
> Diff: https://reviews.apache.org/r/4739/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message