rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anthony Carlucci" <acarlu...@mitre.org>
Subject Re: Review Request: Rave 547, 549, 550
Date Thu, 19 Apr 2012 12:51:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4739/#review7025
-----------------------------------------------------------

Ship it!


Found one minor thing - extra random 's' character in the default.css.  I will remove when
I apply the patch.

- Anthony


On 2012-04-19 02:49:13, Erin Noe-Payne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4739/
> -----------------------------------------------------------
> 
> (Updated 2012-04-19 02:49:13)
> 
> 
> Review request for rave.
> 
> 
> Summary
> -------
> 
> Rave 547, 549, 550
> 
> Implement container.views.createElementForGadget to support gadgets.views.openGadget,
supporting slideout, modal, and dialog popups.
> 
> 
> Diffs
> -----
> 
>   trunk/rave-demo-gadgets/src/main/webapp/open_views_demo.xml PRE-CREATION 
>   trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1326730 
>   trunk/rave-portal-resources/src/main/webapp/css/default.css 1326730 
>   trunk/rave-portal-resources/src/main/webapp/script/rave.js 1326730 
>   trunk/rave-portal-resources/src/main/webapp/script/rave_opensocial.js 1326730 
>   trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/config/OpenSocialEnvironment.java
1326730 
> 
> Diff: https://reviews.apache.org/r/4739/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message