rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erin Noe-Payne" <eri...@mitre.org>
Subject Re: Review Request: Creating new webservices using CXF
Date Mon, 18 Mar 2013 14:21:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9959/#review18052
-----------------------------------------------------------


Looks great so far. My only comments are - 

1. We may not want to deliver the api from the /portal path? 
2. I would expect to key off of {{id}} rather than {{username}}. Matt mentioned that this
was due to rave's persistence where in the past id was referring to a table id.  Now that
we have an abstract implementation we should probably key users (and anything else) off of
id though.

- Erin Noe-Payne


On March 15, 2013, 6:52 p.m., Chris Geer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9959/
> -----------------------------------------------------------
> 
> (Updated March 15, 2013, 6:52 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> ** This is not meant to be a final release. Just posting this so people can see/comment
on the direction **
> 
> Creating new web services using CXF. New service is accessible at http://localhost:8080/portal/api/rest/
> 
> http://localhost:8080/portal/api/rest/people
> http://localhost:8080/portal/api/rest/people/123
> http://localhost:8080/portal/api/rest/people/123/friends
> 
> As part of this I'm using the new proposed package structure where base functionality
would move to org.apache.rave and leave org.apache.rave.portal to the portal implementation
on top of the core. There is also a new module called rave-core-api which will hold the API.

> 
> 
> This addresses bug RAVE-910.
>     https://issues.apache.org/jira/browse/RAVE-910
> 
> 
> Diffs
> -----
> 
>   /trunk/pom.xml 1453622 
>   /trunk/rave-components/pom.xml 1453622 
>   /trunk/rave-components/rave-core-api/pom.xml PRE-CREATION 
>   /trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/PeopleResource.java
PRE-CREATION 
>   /trunk/rave-components/rave-core/pom.xml 1453622 
>   /trunk/rave-components/rave-core/src/main/java/org/apache/rave/rest/impl/DefaultPeopleResource.java
PRE-CREATION 
>   /trunk/rave-portal-dependencies/pom.xml 1453622 
>   /trunk/rave-portal-resources/pom.xml 1453622 
>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/applicationContext.xml 1453622

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/cxf-applicationContext.xml PRE-CREATION

>   /trunk/rave-portal-resources/src/main/webapp/WEB-INF/web.xml 1453622 
> 
> Diff: https://reviews.apache.org/r/9959/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Geer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message