rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Geer <ch...@cxtsoftware.com>
Subject Re: CXF Rest + WS Data Model
Date Fri, 22 Mar 2013 16:13:34 GMT
On Fri, Mar 22, 2013 at 5:42 AM, Matt Franklin <m.ben.franklin@gmail.com>wrote:

> On Thursday, March 21, 2013, Chris Geer wrote:
>
> > On Thu, Mar 21, 2013 at 4:32 PM, Matt Franklin <m.ben.franklin@gmail.com
> <javascript:;>
> > >wrote:
> >
> > > On Thu, Mar 21, 2013 at 5:32 PM, Chris Geer <chris@cxtsoftware.com
> <javascript:;>>
> > wrote:
> > > > I've done a first cut at adding some new CXF based REST web services
> > > which
> > > > use a different data model and uploaded a patch to the ticket [1]. I
> > > tried
> > > > to upload to Review Board but it was too big I think. The biggest
> > change
> > > is
> > > > I had to relocate all the model interfaces from
> > > > rave-core/org.apache.rave.portal.model ->
> > > > rave-core-api/org.apache.rave.model. We would have to had do
> > > > it eventually but I needed to do it now to build the conversions
> > between
> > > > the models. One nice thing is that the web services support partial
> > data
> > > > objects so we can limit fields on retrieval for security reasons and
> we
> > > can
> > > > accept partial updates.
> > > >
> > > > At this point I'd like to commit this small step because I don't want
> > to
> > > > get into a situation where the model is being changes in trunk in the
> > old
> > > > location and by me in the new location which will cause major merge
> > > issues.
> > > > If there are any objections I can move all these changes to a branch
> > and
> > > we
> > > > can deal with the merge issues later.
> > >
> > > IMO, it would be better to make some of these changes incrementally
> > > and without review. Specifically, refactoring and package structure
> > > changes are too big to commit as one single patch.
> > >
> >
> > Incrementally is the challenge since things are so intertwined. I don't
> > mind doing it without review, just more of a heads up that all the model
> > interfaces are moving to a new module/package.
>
>
> +1 for the move
>

Change is checked in. I've tested to the best of my ability but please let
me know if you find issues and I'll fix them.

>
>
> >
> > >
> > > >
> > > > Chris
> > > >
> > > > [1] https://issues.apache.org/jira/browse/RAVE-910
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message