rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request 14841: Upgrade to Shindig 2.5.0-update1
Date Tue, 12 Nov 2013 15:17:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14841/#review28740
-----------------------------------------------------------



https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaApplicationDataRepository.java
<https://reviews.apache.org/r/14841/#comment55721>

    The deserialize data method as it exists in this instance would result in string representations
of objects if they are deeper than one level.  I assumed the reason that Shindig moved to
Map<String, Object> was to avoid forcing clients to parse JSON strings, as the entire
object tree would serialize correctly to a JS object.  
    
    The new pattern deserializes the "serializeddata" field into a Map<String, Object>
using a utility class.  


- Matt Franklin


On Oct. 22, 2013, 1:21 p.m., Stanton Sievers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14841/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 1:21 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Bugs: RAVE-1068
>     https://issues.apache.org/jira/browse/RAVE-1068
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> With the release of Shindig 2.5.0-update1[1] I think it would be good to upgrade Rave
to a release version of Shindig.
> 
> [1] http://mail-archives.apache.org/mod_mbox/www-announce/201310.mbox/%3CCAB56zCWRFeCeaqkatiN2PPxfDMvx5ncVcFfSe4-EtTo2u3vy%2Bg%40mail.gmail.com%3E
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/pom.xml 1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/model/ApplicationData.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/ApplicationDataImpl.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaApplicationData.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaApplicationDataRepository.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaApplicationDataConverterTest.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaApplicationDataRepositoryTest.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultActivityStreamsService.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultAppDataService.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/main/java/org/apache/rave/opensocial/service/impl/DefaultPersonService.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/AppDataServiceTest.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-core/src/test/java/org/apache/rave/opensocial/service/DefaultActivityStreamsServiceTest.java
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig-resources/src/main/resources/rave.shindig.properties
1534624 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-server/rave-shindig-resources/src/main/webapp/WEB-INF/classes/containers/default/container.js
1534624 
> 
> Diff: https://reviews.apache.org/r/14841/diff/
> 
> 
> Testing
> -------
> 
> Existing unit tests and integration tests pass.
> 
> 
> Thanks,
> 
> Stanton Sievers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message