rave-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Franklin" <mfrank...@apache.org>
Subject Re: Review Request 15430: RAVE-1075
Date Wed, 13 Nov 2013 14:08:19 GMT


> On Nov. 12, 2013, 12:15 a.m., Chris Geer wrote:
> > https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/model/Widget.java,
line 56
> > <https://reviews.apache.org/r/15430/diff/1/?file=382184#file382184line56>
> >
> >     I think during some of the initial conversations we said this would be a JSON
chunk (regardless if the serialization was JSON or XML for the web service). If that is the
case, does it makes sense to make this a JSONNode or something similar to ensure that is what
it is? A concern about making it a <String, Object> hash is there is no guarantee the
object is serializable as JSON/XML.
> 
> Matt Franklin wrote:
>     You are correct that there is no guarantee though using something like a JsonNode
doesn't seem like the right choice.  FWIW, this follows the Shindig pattern for the same thing.

Is this a blocking issue?  If not, I will commit it later today.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15430/#review28711
-----------------------------------------------------------


On Nov. 11, 2013, 8:47 p.m., Matt Franklin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15430/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 8:47 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> Posting for comment before committing as this is a change in pattern
> 
> 
> Diffs
> -----
> 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/model/Widget.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core-api/src/main/java/org/apache/rave/rest/model/Widget.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/impl/WidgetImpl.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/main/java/org/apache/rave/rest/impl/DefaultWidgetsResource.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-core/src/test/java/org/apache/rave/rest/impl/DefaultWidgetsResourceTest.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaPage.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/JpaWidget.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/model/conversion/JpaWidgetConverter.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/main/java/org/apache/rave/portal/repository/impl/JpaWidgetRepository.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/model/conversion/JpaWidgetConverterTest.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/java/org/apache/rave/portal/repository/impl/JpaWidgetRepositoryTest.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-jpa/src/test/resources/test_data.sql
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-mongodb/src/main/java/org/apache/rave/portal/model/conversion/impl/MongoDbWidgetConverter.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-components/rave-mongodb/src/test/java/org/apache/rave/portal/model/conversion/impl/MongoDbWidgetConverterTest.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/main/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetWrapperRenderer.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-opensocial-provider/rave-opensocial-client/src/test/java/org/apache/rave/provider/opensocial/web/renderer/OpenSocialWidgetRendererTest.java
1540830 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cRegionWidgetRenderer.java
PRE-CREATION 
>   https://svn.apache.org/repos/asf/rave/trunk/rave-providers/rave-w3c-provider/src/main/java/org/apache/rave/provider/w3c/web/renderer/W3cWidgetWrapperRenderer.java
1540830 
> 
> Diff: https://reviews.apache.org/r/15430/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Franklin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message